Avoid using a global registry client when downloading OCI helm charts #3938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how we instantiate the `registryClient` used when downloading helm charts stored in OCI registries. It fixes race conditions that could lead to `Not Logged In` or even authentication problems. Refers to: rancher#3915 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
3915-non-global-registry-client
branch
from
dbebcad to
610787a
Compare
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Aug 5, 2025
…rancher#3938) This changes how we instantiate the `registryClient` used when downloading helm charts stored in OCI registries. It fixes race conditions that could lead to `Not Logged In` or even authentication problems. Refers to: rancher#3915 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Aug 5, 2025
…rancher#3938) This changes how we instantiate the `registryClient` used when downloading helm charts stored in OCI registries. It fixes race conditions that could lead to `Not Logged In` or even authentication problems. Refers to: rancher#3915 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Aug 5, 2025
…rancher#3938) This changes how we instantiate the `registryClient` used when downloading helm charts stored in OCI registries. It fixes race conditions that could lead to `Not Logged In` or even authentication problems. Refers to: rancher#3915 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Aug 5, 2025
…rancher#3938) This changes how we instantiate the `registryClient` used when downloading helm charts stored in OCI registries. It fixes race conditions that could lead to `Not Logged In` or even authentication problems. Refers to: rancher#3915 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we instantiate the
registryClientused when downloading helm charts stored in OCI registries. It fixes race conditions that could lead toNot Logged Inor even authentication problems.Refers to: #3915
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.