Support graceful agent shutdown #3918
Merged
+171
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thardeck
requested changes
Jul 28, 2025
Good shout, I've added end-to-end tests in a separate commit (see |
The Fleet agent must be able to properly handle `SIGTERM`, which amounts to exiting with error code 0 (instead of 1) when its context is canceled.
New end-to-end test cases for SIGTERM handling should uncover possible future regressions such as the one fixed by the previous commit.
weyfonk
force-pushed
the
3851-agent-signal-handling
branch
from
8113b5e to
b909388
Compare
That configuration is consistent with what `dev/setup-fleet` does, which is itself aligned on Rancher behaviour.
Some signal handling test cases would fail because running `kubectl exec` against a deployment name would not necessarily run the command in that same deployment based on an exact name match. To work around this, we now compute pod names for the right combination of labels, including shard IDs, and run `kubectl exec` directly against the resolved pod.
weyfonk
force-pushed
the
3851-agent-signal-handling
branch
from
b909388 to
1e2814a
Compare
thardeck
approved these changes
Jul 29, 2025
weyfonk
added a commit
to weyfonk/fleet
that referenced
this pull request
Jul 29, 2025
The Fleet agent must be able to properly handle `SIGTERM`, which amounts to exiting with error code 0 (instead of 1) when its context is canceled. New end-to-end test cases for SIGTERM handling should uncover possible future regressions such as the one fixed by the previous commit. * Deploy the Fleet agent into namespace `cattle-fleet-local-system` That configuration is consistent with what `dev/setup-fleet` does, which is itself aligned on Rancher behaviour.
thardeck
pushed a commit
that referenced
this pull request
Jul 30, 2025
The Fleet agent must be able to properly handle `SIGTERM`, which amounts to exiting with error code 0 (instead of 1) when its context is canceled. New end-to-end test cases for SIGTERM handling should uncover possible future regressions such as the one fixed by the previous commit. * Deploy the Fleet agent into namespace `cattle-fleet-local-system` That configuration is consistent with what `dev/setup-fleet` does, which is itself aligned on Rancher behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fleet agent must be able to properly handle
SIGTERM, which amounts to exiting with error code 0 (instead of 1) when its context is canceled.Refers to #3919.
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.