Changes job handling in gitops controller #2903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
force-pushed
the
2870-clean-successful-jobs
branch
4 times, most recently
from
b12b7b9 to
d2a85d8
Compare
manno
changed the title
0xavi0
force-pushed
the
2870-clean-successful-jobs
branch
3 times, most recently
from
d496fa9 to
e6cb13b
Compare
weyfonk
reviewed
Sep 30, 2024
1 task
0xavi0
force-pushed
the
2870-clean-successful-jobs
branch
3 times, most recently
from
2a532e9 to
9afd993
Compare
Changes the job handling so jobs are deleted after they succeed. Jobs are created when they are needed, this avoids having always a minimum of 1 job per `gitrepo` resource. It also deletes the Owns(job) statement from the reconciler setup as we're already setting the controller reference when creating the job and the Owns statement makes extra reconciler calls that are not needed. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
2870-clean-successful-jobs
branch
from
9afd993 to
dadd231
Compare
Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
2870-clean-successful-jobs
branch
from
dadd231 to
453ceea
Compare
weyfonk
reviewed
Oct 1, 2024
Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
weyfonk
approved these changes
Oct 1, 2024
3 tasks
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Oct 3, 2024
The job also deletes all completed gitjobs, not leaving the last one active, as rancher#2903 was merged. Also fixes the ServiceAccount to be able to list and delete jobs. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Oct 4, 2024
The job also deletes all completed gitjobs, not leaving the last one active, as rancher#2903 was merged. Also fixes the ServiceAccount to be able to list and delete jobs. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Oct 7, 2024
* Changes job handling in gitopts controller Changes the job handling so jobs are deleted after they succeed. Jobs are created when they are needed, this avoids having always a minimum of 1 job per `gitrepo` resource. It also deletes the Owns(job) statement from the reconciler setup as we're already setting the controller reference when creating the job and the Owns statement makes extra reconciler calls that are not needed. --------- Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
that referenced
this pull request
Oct 7, 2024
The job also deletes all completed gitjobs, not leaving the last one active, as #2903 was merged. Also fixes the ServiceAccount to be able to list and delete jobs. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
3 tasks
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Oct 7, 2024
The job also deletes all completed gitjobs, not leaving the last one active, as rancher#2903 was merged. Also fixes the ServiceAccount to be able to list and delete jobs. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
that referenced
this pull request
Oct 7, 2024
* Changes job handling in gitops controller (#2903) * Changes job handling in gitopts controller Changes the job handling so jobs are deleted after they succeed. Jobs are created when they are needed, this avoids having always a minimum of 1 job per `gitrepo` resource. It also deletes the Owns(job) statement from the reconciler setup as we're already setting the controller reference when creating the job and the Owns statement makes extra reconciler calls that are not needed. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
added a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the job handling so jobs are deleted after they succeed. Jobs are created when they are needed, this avoids having always a minimum of 1 job per
gitreporesource.It also deletes the Owns(job) statement from the reconciler setup as we're already setting the controller reference when creating the job and the Owns statement makes extra reconciler calls that are not needed.
Refers to #2870