[v0.10] Fix helm.sh/resource-policy being added to everything and not just CRDs #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `deleteCRDResources` was disabled (default), the `helm.sh/resource-policy` annotation was added to almost all resources instead of just to the CRDs as it was intended. The fix is to not change the shared `annotations` that also get added to other resources, but only modify a copy that's only used for one resource. Fixes #2716
weyfonk
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
deleteCRDResourceswas disabled (default), thehelm.sh/resource-policyannotation was added to almost all resources instead of just to the CRDs as it was intended. The fix is to not change the sharedannotationsthat also get added to other resources, but only modify a copy that's only used for one resource.Refers to #2860
Backport of #2850.