[v0.10] Add integration test checks for CA bundle secret #2863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a git job is created for a `GitRepo` with a configured CA bundle, integration tests now validate that a secret is created with the contents of that bundle and validate its contents against the `GitRepo` spec. This also validates through integration tests that RBAC resources and the CA bundle secret are owned by their `GitRepo` and will therefore be deleted as soon as the `GitRepo` is. Validation does not actually delete anything, due to a limitation [1] of the test framework. [1]: https://book.kubebuilder.io/reference/envtest#testing-considerations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2846 to
release/v0.10.Refers to #2829.
When a git job is created for a
GitRepowith a configured CA bundle, integration tests now validate that a secret is created with the contents of that bundle and validate its contents against theGitRepospec.This also validates through integration tests that RBAC resources and the CA bundle secret are owned by their
GitRepoand will therefore be deleted as soon as theGitRepois.Validation does not actually delete anything, due to a limitation 1 of the test framework.