Skip to content

Conversation

@yiannistri
Copy link
Contributor

What this PR does / why we need it:

This PR changes the build process to be self-contained: it no longer requires the application to be build outside the container and relying on go version in the CI runner, instead the build is done in a build layer.

It also uses cross-compilation helpers to invoke the Go compiler with the correct env vars for the target platform.

Which issue(s) this PR fixes
Issue #748

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@yiannistri yiannistri marked this pull request as ready for review December 17, 2024 14:27
@yiannistri yiannistri requested a review from a team as a code owner December 17, 2024 14:27
@yiannistri yiannistri force-pushed the 748-build-release-v2.9 branch from 2446303 to 4b987bd Compare December 17, 2024 14:31
@mjura mjura merged commit 9045ee5 into rancher:release-v2.9 Dec 17, 2024
6 checks passed
@yiannistri yiannistri deleted the 748-build-release-v2.9 branch December 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants