Fix raising errors instead of just logging them by propagating raise_errors in _lazy_load_price_history
#2543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
_lazy_load_price_historywould catch and log errors usinglogger.error, then returnNone, effectively ignoring theraise_errorsparameter passed toticker.history(). This made it difficult to properly handle exceptions downstream.For example, even with the following usage:
the expected exception wasn’t raised (just logged and suppressed). This PR fixes that by properly propagating the
raise_errorsparameter and raising the exception when it's set toTrue.