Skip to content

Support curl_cffi and fix cookie handling #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support curl_cffi and fix cookie handling #2434

wants to merge 3 commits into from

Conversation

@irgb
Copy link

@irgb irgb commented May 2, 2025

fix #2422
fix #2429

Your Name added 2 commits May 2, 2025 13:11
FIX: Add curl_cffi cookies to requests cookies conversion
32e4dc6 
ADD: Implement convert_curl_cffi_cookies_to_requests function in utils.py
MODIFY: Update cookie handling in data.py to use the new conversion function
ADD curl_cffi dependency
4bc7eb1
This was referenced May 2, 2025
Closed
Closed
@ValueRaider
Copy link
Collaborator

Interesting, different approach to #2430. Have you tried it?

@irgb
Copy link
Author

irgb commented May 2, 2025

Interesting, different approach to #2430. Have you tried it?

yes, of course

@ValueRaider
Copy link
Collaborator

Something confuses me:

if isinstance(response.cookies, curl_cffi.requests.cookies.Cookies):

How can response.cookies ever be a curl_cffi.requests.cookies.Cookies?

@irgb
Copy link
Author

irgb commented May 2, 2025

Something confuses me:

if isinstance(response.cookies, curl_cffi.requests.cookies.Cookies):

How can response.cookies ever be a curl_cffi.requests.cookies.Cookies?

You passed a curl_cffi session, and passed it to yfinance as discussed in other issues. Then yfinance will use this session to send a request.

@ValueRaider
Copy link
Collaborator

ValueRaider commented May 2, 2025 •
edited
Loading

Gotcha. Fine as a proof-of-concept but not as a release - curl_cffi session needs to be default automatic.

@bretsky
Copy link
Contributor

bretsky commented May 2, 2025

@ValueRaider that can be accomplished fairly easily, just add the self.session = session or requests.Session(impersonate="chrome") lines to this PR and I think it will just work

MODIFY: Switch HTTP request library from requests to curl_cffi to imp…
0a71f93 
…rove cookie handling

OPTIMIZE: Use chrome browser impersonation when creating Sessions for better compatibility
MODIFY: Update related class docstrings to reflect the new dependency
@ValueRaider
Copy link
Collaborator

FYI I've merged & released the other PR. As emergency over, switch further work to dev branch.

@monik3r monik3r mentioned this pull request May 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AttributeError("'str' object has no attribute 'name'") [0.2.57] YFRateLimitError('Too Many Requests

3 participants

@irgb @ValueRaider @bretsky