Skip to content

feat: Add FastEndpoints snippets #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pm4rcin
Copy link

@pm4rcin pm4rcin commented Oct 3, 2024

This PR adds support for FastEndpoints framework based on C# minimal APIs. Here's the official webpage.

The snippets were copied directly from https://github.com/FastEndpoints/VSCode-Extension/blob/main/snippets/fe-snippets.json

Signed-off-by: Marcin Pachur <pm4rcin.dev.net667@silomails.com>
Copy link
Collaborator

@OkelleyDevelopment OkelleyDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pm4rcin, thanks for the PR!

The changes reviewed look ok so far, but we will need to also update the package.json file to include something equivalent to:

{
   "language": "fastendpoints",
   "path": "./snippets/frameworks/fastendpoints.json"
}

Once that change is added then I think this PR will mostly be ready to merge. Let me know if you have any questions. 🙂

@OkelleyDevelopment
Copy link
Collaborator

Any update here @pm4rcin ?

@pm4rcin
Copy link
Author

pm4rcin commented Apr 22, 2025

Sorry for the long delay but when you commented last time I was not sure if I want this to be merged in this state. Basically I don't like those snippets as I find attributes to be more readable but I was hesitant to change it and I'm not sure if I should duplicate snippets to have both forms or not. Maybe someone else who uses that framework could provide feedback and then we could merge it. In the meantime I'll convert to draft.

@pm4rcin pm4rcin marked this pull request as draft April 22, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants