Skip to content

fix(ironic): do not override OpenStack Helm default paths #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Jun 17, 2025

These paths are defaulted within /var/lib/openstack-helm and should remain that way to avoid cross filesystem operations.

@cardoe cardoe requested a review from a team June 17, 2025 16:52
Copy link
Collaborator

@skrobul skrobul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to update this one too:

containers/dnsmasq/dnsmasq/dnsmasq.conf.j2
98:tftp-root={{ env['TFTP_DIR'] | default('/var/lib/understack/master_iso_images') }}

Also bunch of things in deploy repo still refer to those paths

@cardoe
Copy link
Contributor Author

cardoe commented Jun 17, 2025

Do we want to update this one too:

containers/dnsmasq/dnsmasq/dnsmasq.conf.j2
98:tftp-root={{ env['TFTP_DIR'] | default('/var/lib/understack/master_iso_images') }}

Also bunch of things in deploy repo still refer to those paths

Good find. Yes to both.

@cardoe cardoe force-pushed the fix-ironic-paths branch from 2ecf26a to 3a59504 Compare June 17, 2025 17:10
These paths are defaulted within /var/lib/openstack-helm and should
remain that way to avoid cross filesystem operations.
@cardoe cardoe force-pushed the fix-ironic-paths branch from 3a59504 to eade0a2 Compare June 17, 2025 17:14
@cardoe cardoe added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 863c6ef Jun 18, 2025
28 checks passed
@cardoe cardoe deleted the fix-ironic-paths branch June 18, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants