fix(argocd): deploy as early as possible and don't override upstream resource.exclusions #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are making updates to ArgoCD itself, it needs to sync out first before anything else.
Our list is small and doesn't include everything upstream has identified and included by default so drop our own settings. https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/2.14-3.0/#default-resourceexclusions-configurations https://github.com/argoproj/argo-helm/blob/df0cac1c2c3ad36f21a7f48dd28cbc14ae6b1744/charts/argo-cd/values.yaml#L323
nicholaskuechler
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream has created a broader list of resource.exclusions that should be included. It already includes the one we default along with some others which we currently don't so drop our override to use the upstream one. Set ArgoCD to deploy as early as possible.