Skip to content

Conversation

@rackerchris
Copy link
Contributor

@rackerchris rackerchris commented Oct 29, 2025

Feature:Refactor Service Installation Scripts to Use Standard Template

This PR updates all services install/upgrade script to conform to the standard bash template.
Key Changes & Benefits:

  • Standardization: Adopts the robust, array-based command construction (helm_command) for safer execution and argument quoting.
  • Dynamic Values Loading: Switches to the standard loop logic for reliably including all .yaml files from both the base and custom override directories (/opt/genestack/base-helm-configs/redis-sentinel and /etc/genestack/helm-configs/redis-sentinel).
  • Improved Reliability: Ensures consistent extraction of the service chart version using the defined SERVICE_NAME variable.
  • GITHUB ACTIONS: Ensures that a github action exists for each service for pre-commit checking

This change reduces technical debt and makes the script easier to audit and maintain.

@rackerchris rackerchris force-pushed the install-redis-sentinel branch 2 times, most recently from aac274f to ab1e4a9 Compare October 29, 2025 22:20
@rackerchris rackerchris marked this pull request as draft October 29, 2025 22:39
@rackerchris rackerchris force-pushed the install-redis-sentinel branch from ab1e4a9 to 5dcd6ef Compare October 29, 2025 23:42
@rackerchris rackerchris force-pushed the install-redis-sentinel branch from 5dcd6ef to 4a550b4 Compare October 29, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant