ref: don't pass event around but bufnr, use autocmd event #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like the other PR, it's really great. Now that you say it, it's true that passing around Thank you ! |
|
Ah... there is a lots of conflicts. Can you maybe send a PR from your |
Kazy
force-pushed
the
ref-au-event-bufnr
branch
from
825abf0 to
0e8e6b1
Compare
|
Thank you a lot ! |
|
I didn't get to even send my message to say that I had rebased the PR :p Thanks for the fast review and merge, appreciate ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't impact anything feature wise nor does it fix any bug, but when implementing #115, I initially lost a bit of time trying to understand why the
eventfrom theDiagnosticChangeddidn't have thediagnosticsfield. The main problem was that in each autocmd we're reading the event passed fromLspAttachinstead of the one from the triggered event itself.This changes that and also only pass the buffer number around instead of the event to make things clearer. I've also moved the insertion of values into
DISABLED_MODESoutside of theLspAttachevent to avoid duplicating the entries in it for nothing.If you want to see a merged version of it with #115, you can check https://github.com/Kazy/tiny-inline-diagnostic.nvim/tree/integrated.