Skip to content

FnOnce as Producer::send callback #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions protocol/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,5 @@ num_enum = "0.7.0"
derive_more = "0.99"

[dev-dependencies]
fake = { version = "3.0", features=['derive', 'chrono','uuid']}
rand = "0.8"
pretty_assertions = "1.2.0"
fake = { version = "4.0", features = [ "derive", "chrono", "uuid" ] }
3 changes: 0 additions & 3 deletions protocol/src/commands/close.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct CloseRequest {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/consumer_update.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/consumer_update_request.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/create_stream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct CreateStreamCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/create_super_stream.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
use std::collections::HashMap;
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/credit.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/declare_publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct DeclarePublisherCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/delete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct Delete {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/delete_publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct DeletePublisherCommand {
Expand Down
4 changes: 0 additions & 4 deletions protocol/src/commands/delete_super_stream.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down Expand Up @@ -62,7 +59,6 @@ impl Command for DeleteSuperStreamCommand {

#[cfg(test)]
mod tests {
use crate::commands::create_super_stream::CreateSuperStreamCommand;
use crate::commands::tests::command_encode_decode_test;

use super::DeleteSuperStreamCommand;
Expand Down
4 changes: 1 addition & 3 deletions protocol/src/commands/deliver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ use crate::{
protocol::commands::COMMAND_DELIVER,
};
use byteorder::{BigEndian, WriteBytesExt};
#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug, Clone)]
Expand Down Expand Up @@ -163,7 +161,7 @@ mod tests {

use super::{DeliverCommand, Message};
impl Dummy<Faker> for Message {
fn dummy_with_rng<R: rand::Rng + ?Sized>(_config: &Faker, _rng: &mut R) -> Self {
fn dummy_with_rng<R: fake::rand::Rng + ?Sized>(_config: &Faker, _rng: &mut R) -> Self {
Message::new(InternalMessage::default())
}
}
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/exchange_command_versions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ use crate::{
use super::Command;
use byteorder::{BigEndian, WriteBytesExt};

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct ExchangeCommandVersion(u16, u16, u16);
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/generic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ use crate::{
FromResponse, ResponseCode, ResponseKind,
};

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct GenericResponse {
Expand Down
2 changes: 0 additions & 2 deletions protocol/src/commands/metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ use crate::{
use super::Command;

use byteorder::{BigEndian, WriteBytesExt};
#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
Expand Down
2 changes: 0 additions & 2 deletions protocol/src/commands/metadata_update.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ use crate::{
use super::Command;

use crate::codec::Encoder;
#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/open.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct OpenCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/peer_properties.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct PeerPropertiesCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/publish.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ use super::Command;

use crate::types::PublishedMessage;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct PublishCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/publish_confirm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct PublishConfirm {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/publish_error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ use std::io::Write;

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct PublishErrorResponse {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/query_offset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ use std::io::Write;

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct QueryOffsetRequest {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/query_publisher_sequence.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ use std::io::Write;

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct QueryPublisherRequest {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/sasl_authenticate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct SaslAuthenticateCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/sasl_handshake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct SaslHandshakeCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/store_offset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ use std::io::Write;

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct StoreOffset {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/subscribe.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
use std::collections::HashMap;
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/superstream_partitions.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use super::Command;
use crate::{
codec::{Decoder, Encoder},
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/superstream_route.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/tune.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ use crate::{

use super::Command;

#[cfg(test)]
use fake::Fake;

#[cfg_attr(test, derive(fake::Dummy))]
#[derive(PartialEq, Eq, Debug)]
pub struct TunesCommand {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/commands/unsubscribe.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use std::io::Write;

#[cfg(test)]
use fake::Fake;

use crate::{
codec::{Decoder, Encoder},
error::{DecodeError, EncodeError},
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/message/amqp/body.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ mod tests {

use super::MessageBody;
impl Dummy<Faker> for MessageBody {
fn dummy_with_rng<R: rand::Rng + ?Sized>(config: &Faker, rng: &mut R) -> Self {
fn dummy_with_rng<R: fake::rand::Rng + ?Sized>(config: &Faker, rng: &mut R) -> Self {
MessageBody {
data: config.fake_with_rng(rng),
sequence: config.fake_with_rng(rng),
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/message/amqp/header.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ use super::{
types::{list_decoder, Boolean, List},
AmqpDecodeError, AmqpDecoder, AmqpEncodeError, AmqpEncoder,
};
#[cfg(test)]
use fake::Fake;

/// Header of the message
#[derive(Clone, Debug, PartialEq, Eq)]
#[cfg_attr(test, derive(fake::Dummy))]
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/message/amqp/message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ use super::section::MessageSection;
use super::types::{ApplicationProperties, DeliveryAnnotations, Footer, MessageAnnotations};
use super::{AmqpDecodeError, AmqpDecoder};

#[cfg(test)]
use fake::Fake;

#[derive(Debug, Clone, Default, PartialEq, Eq)]
#[cfg_attr(test, derive(fake::Dummy))]
pub struct Message {
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/message/amqp/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ mod tests {
where
T: Dummy<Faker> + AmqpDecoder + AmqpEncoder + Debug + PartialEq,
{
let mut rng = rand::thread_rng();
let mut rng = fake::rand::rng();
let len: usize = DEFAULT_LEN_RANGE.fake_with_rng(&mut rng);

for _ in 0..len {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/message/amqp/properties.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ use super::{
AmqpEncodeError, AmqpEncoder,
};

#[cfg(test)]
use fake::Fake;

/// Properties of the message
#[derive(Clone, Debug, PartialEq, Eq, Default)]
#[cfg_attr(test, derive(fake::Dummy))]
Expand Down
2 changes: 0 additions & 2 deletions protocol/src/message/amqp/types/annotations.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ use crate::{
};

use super::{Long, Map, Symbol, ULong, Value};
#[cfg(test)]
use fake::Fake;

/// Key for annotations [`Map`]
#[derive(Debug, Clone, Hash, PartialEq, Eq)]
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/message/amqp/types/descriptor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ use crate::message::amqp::codec::{AmqpDecoder, AmqpEncoder};
use crate::message::amqp::error::{AmqpDecodeError, AmqpEncodeError};
use crate::utils::TupleMapperSecond;

#[cfg(test)]
use fake::Fake;

#[derive(Debug, PartialEq, Eq, Clone, Hash)]
#[cfg_attr(test, derive(fake::Dummy))]
pub enum Descriptor {
Expand Down
3 changes: 0 additions & 3 deletions protocol/src/message/amqp/types/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ pub use primitives::*;

use super::{codec::constants::TypeCode, AmqpDecoder, AmqpEncodeError, AmqpEncoder};

#[cfg(test)]
use fake::Fake;

mod annotations;
mod definitions;
mod descriptor;
Expand Down
Loading
Loading