Skip to content

cleanup unused connections when load balancing mode is active #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

DanielePalaia
Copy link
Contributor

This closes #236

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.53%. Comparing base (ac1f614) to head (8267660).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/consumer.rs 0.00% 2 Missing ⚠️
src/producer.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   89.59%   89.53%   -0.06%     
==========================================
  Files          78       78              
  Lines        6658     6662       +4     
==========================================
  Hits         5965     5965              
- Misses        693      697       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it works!

@DanielePalaia DanielePalaia merged commit 4f78182 into main Oct 31, 2024
2 of 4 checks passed
@DanielePalaia DanielePalaia deleted the close_connections_when_lbm_is_set branch October 31, 2024 09:13
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review connections handling when Load Balancing mode is active
2 participants