Adapt the heartbeat checker to the configuration. #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the configuration. In case a heartbeat less than 20 seconds the client could raise missing heart beat. In some case could disconnect the client Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Gsantomaggio
changed the title
hiimjako
reviewed
Nov 22, 2024
Co-authored-by: Alberto Moretti <58828402+hiimjako@users.noreply.github.com>
That is my fault. I interpreted the missing heartbeat as a correct closure, but it is not. We need to do the same I did here: rabbitmq/rabbitmq-stream-dotnet-client#394 |
hiimjako
previously approved these changes
Nov 22, 2024
Co-authored-by: Alberto Moretti <58828402+hiimjako@users.noreply.github.com>
the configuration. In case a heartbeat less than 20 seconds the client could raise missing heart beat. In some case could disconnect the client Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the configuration. In case a heartbeat less than 20 seconds the client could raise missing heart beat. In some case could disconnect the client