Skip to content

Add BatchSend to HA Producer #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions pkg/ha/ha_publisher.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@ package ha
import (
"errors"
"fmt"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/logs"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/message"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/stream"
"strings"
"sync"
"sync/atomic"
"time"

"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/logs"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/message"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/stream"
)

func (p *ReliableProducer) handlePublishConfirm(confirms stream.ChannelPublishConfirm) {
Expand Down Expand Up @@ -109,12 +110,13 @@ func (p *ReliableProducer) newProducer() error {
return err
}

func (p *ReliableProducer) Send(message message.StreamMessage) error {
func (p *ReliableProducer) isReadyToSend() error {
if p.GetStatus() == StatusStreamDoesNotExist {
return stream.StreamDoesNotExist
}

if p.GetStatus() == StatusClosed {
return errors.New(fmt.Sprintf("%s is closed", p.getInfo()))
return fmt.Errorf("%s is closed", p.getInfo())
}

if p.GetStatus() == StatusReconnecting {
Expand All @@ -123,11 +125,10 @@ func (p *ReliableProducer) Send(message message.StreamMessage) error {
logs.LogDebug("[Reliable] %s reconnected. The send is unlocked", p.getInfo())
}

p.mutex.Lock()
defer p.mutex.Unlock()

errW := p.producer.Send(message)
return nil
}

func (p *ReliableProducer) checkWriteError(errW error) error {
if errW != nil {
switch {
case errors.Is(errW, stream.FrameTooLarge):
Expand All @@ -138,10 +139,32 @@ func (p *ReliableProducer) Send(message message.StreamMessage) error {
time.Sleep(500 * time.Millisecond)
logs.LogError("[Reliable] %s - error during send %s", p.getInfo(), errW.Error())
}
}
return nil
}

func (p *ReliableProducer) Send(message message.StreamMessage) error {
if err := p.isReadyToSend(); err != nil {
return err
}

return nil
p.mutex.Lock()
errW := p.producer.Send(message)
p.mutex.Unlock()

return p.checkWriteError(errW)
}

func (p *ReliableProducer) BatchSend(batchMessages []message.StreamMessage) error {
if err := p.isReadyToSend(); err != nil {
return err
}

p.mutex.Lock()
errW := p.producer.BatchSend(batchMessages)
p.mutex.Unlock()

return p.checkWriteError(errW)
}

func (p *ReliableProducer) IsOpen() bool {
Expand Down
19 changes: 15 additions & 4 deletions pkg/ha/ha_publisher_test.go
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
package ha

import (
"sync/atomic"
"time"

"github.com/google/uuid"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/amqp"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/message"
. "github.com/rabbitmq/rabbitmq-stream-go-client/pkg/stream"
"github.com/rabbitmq/rabbitmq-stream-go-client/pkg/test-helper"
"sync/atomic"
"time"
test_helper "github.com/rabbitmq/rabbitmq-stream-go-client/pkg/test-helper"
)

var _ = Describe("Reliable Producer", func() {
Expand Down Expand Up @@ -44,14 +46,15 @@ var _ = Describe("Reliable Producer", func() {
})

It("Create/Confirm and close a Reliable Producer", func() {
const expectedMessages = 20
signal := make(chan struct{})
var confirmed int32
producer, err := NewReliableProducer(envForRProducer,
streamForRProducer, NewProducerOptions(), func(messageConfirm []*ConfirmationStatus) {
for _, confirm := range messageConfirm {
Expect(confirm.IsConfirmed()).To(BeTrue())
}
if atomic.AddInt32(&confirmed, int32(len(messageConfirm))) == 10 {
if atomic.AddInt32(&confirmed, int32(len(messageConfirm))) == expectedMessages {
signal <- struct{}{}
}
})
Expand All @@ -61,6 +64,14 @@ var _ = Describe("Reliable Producer", func() {
err := producer.Send(msg)
Expect(err).NotTo(HaveOccurred())
}

for i := 0; i < 5; i++ {
msg1 := amqp.NewMessage([]byte("ha_batch_1"))
msg2 := amqp.NewMessage([]byte("ha_batch_2"))
batch := []message.StreamMessage{msg1, msg2}
err := producer.BatchSend(batch)
Expect(err).NotTo(HaveOccurred())
}
<-signal
Expect(producer.Close()).NotTo(HaveOccurred())
})
Expand Down