Fix heartbeat frame handle #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gsantomaggio
approved these changes
Aug 1, 2023
Heartbeat frame is just a header frame. We were reading the header once, and then reading 4 bytes again, during the handle of the hearbeat frame. That was missaligning the buffer and causing a panic on next iteration. Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
Zerpet
force-pushed
the
zerpet/fix-heartbeat-handle
branch
from
6e9a3eb to
88f8134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Heartbeat frame is just a header frame. We were reading the header once,
and then reading 4 bytes again, during the handle of the hearbeat frame.
That was missaligning the buffer and causing a panic on next iteration.