Skip to content

Lock Message dispatch during the promotion #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
Merged

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented May 27, 2025

When a single active consumer moves from active to inactive, the messages dispatch needs to be locked during the consumer listener update to prevent messages from being dispatched.

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
when the consumer is in single active consumer

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio changed the title lock update listener Lock Message dispatch during the promotion May 27, 2025
@Gsantomaggio
Copy link
Member Author

cc @jonnepmyra Please let me know. No rush!

@Gsantomaggio Gsantomaggio marked this pull request as ready for review May 28, 2025 06:39
@jonnepmyra
Copy link
Contributor

This seems to do the trick -Thanks for the update!

@Gsantomaggio Gsantomaggio merged commit b5d784f into main May 28, 2025
2 checks passed
@Gsantomaggio Gsantomaggio deleted the lock_update_consumer branch May 28, 2025 08:51
@Gsantomaggio Gsantomaggio added the bug Something isn't working label May 28, 2025
@Gsantomaggio Gsantomaggio added this to the 1.8.14 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants