Expose Store offset to stream system #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2025 08:21
…be used when you're not in the context of a messagehandler
|
@jonnepmyra can you format the code? |
|
Some background to this PR.... In a message handler for a However, there are use cases where offset storage is needed outside of the message handling flow. For example when the application is shutting down and we want to explicitly call This PR addresses that need |
|
That's what I need. I try to process messages in batch so I saved and updated a reference to RawConsumer(I'm not sure. It might be disposed later, right?) just for calling StroeOffset. Now I could get rid of it and just call StoreOffset by StreamSystem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose Store offset to stream system