Last offset fix #407
Merged
Last offset fix #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 26, 2025 07:33
…ler is called. This change does it after the messagehandler is called in order to avoid potential messageloss on the event of connection-issues/reconnecting-consumer
Gsantomaggio
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the reliable consumer tracks the lastOffsetConsumed correctly, allowing it to reconnect to the correct offset in the event of a reconnection.
Before this PR:
The lastOffsetConsumed was recorded before the message handler was executed, which could result in potential message loss during connection issues or consumer reconnections.
After this PR:
The lastOffsetConsumed will be stored after the message handler is executed, preventing message loss in the event of connection issues or reconnections.