Updated Secret try to reconnect the client #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 6, 2024 14:55
the test is not need since the function updatesecrets has to check if the locator is up and running like the other functions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 92.05% 91.94% -0.12%
==========================================
Files 118 118
Lines 12075 12103 +28
Branches 930 936 +6
==========================================
+ Hits 11116 11128 +12
- Misses 741 757 +16
Partials 218 218 ☔ View full report in Codecov by Sentry. |
Gsantomaggio
changed the title
The passowrd can change with the update secret so here we merge the current configuration with the new possible configuration in order to use the last valid password
|
Thanks @Gsantomaggio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #363
The new password is set before trying to reconnect