Skip to content

Test mixed version with 3.13.7/OTP26 #14171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 95 additions & 95 deletions .github/workflows/oci-make.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,98 +32,98 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
jobs:
build-package-generic-unix:
strategy:
matrix:
otp_version:
- ${{ github.event.inputs.otp_version || '28' }}
runs-on: ubuntu-latest
outputs:
# When dependabot, or a user from a fork, creates PRs, secrets are not injected, and the OCI workflow can't push the image
# This check acts as a gate keeper
authorized: ${{ steps.authorized.outputs.authorized }}
steps:
- name: CHECK IF IMAGE WILL PUSH
id: authorized
run: |
if [ -n "${{ secrets.DOCKERHUB_PASSWORD }}" ]; then
echo "authorized=true" | tee -a $GITHUB_OUTPUT
else
echo "authorized=false" | tee -a $GITHUB_OUTPUT
fi
- name: Checkout
if: steps.authorized.outputs.authorized == 'true'
uses: actions/checkout@v4
- name: Configure Erlang
if: steps.authorized.outputs.authorized == 'true'
uses: erlef/setup-beam@v1
with:
otp-version: ${{ matrix.otp_version }}
elixir-version: latest
- name: make package-generic-unix
if: steps.authorized.outputs.authorized == 'true'
run: |
make package-generic-unix PROJECT_VERSION=${{ env.VERSION }}
- name: Upload package-generic-unix
if: steps.authorized.outputs.authorized == 'true'
uses: actions/upload-artifact@v4
with:
name: package-generic-unix-otp${{ matrix.otp_version }}
path: PACKAGES/rabbitmq-server-*.tar.xz

build-and-push:
strategy:
fail-fast: false
matrix:
otp_version:
- ${{ github.event.inputs.otp_version || '28' }}
needs: build-package-generic-unix
runs-on: ubuntu-latest
if: ${{ needs.build-package-generic-unix.outputs.authorized }} == 'true'
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Download package-generic-unix
uses: actions/download-artifact@v4
with:
name: package-generic-unix-otp${{ matrix.otp_version }}
path: PACKAGES
- name: Rename package-generic-unix
run: |
cp \
PACKAGES/rabbitmq-server-generic-unix-*.tar.xz \
packaging/docker-image/package-generic-unix.tar.xz
- name: Docker meta
id: meta
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY_IMAGE }}
flavor: |
suffix=-otp${{ matrix.otp_version }}
tags: |
type=ref,event=branch
type=ref,event=pr
type=sha,format=long
- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
- name: Build and push by digest
id: build
uses: docker/build-push-action@v6
with:
push: true
context: packaging/docker-image
labels: ${{ steps.meta.outputs.labels }}
platforms: ${{ github.event.inputs.build_arm && 'linux/amd64, linux/arm64' || 'linux/amd64' }}
tags: ${{ steps.meta.outputs.tags }}
cache-to: type=gha,mode=max,scope=${{ matrix.otp_version }}
cache-from: type=gha,scope=${{ matrix.otp_version }}
build-args: |
OTP_VERSION=${{ matrix.otp_version }}
RABBITMQ_VERSION=${{ env.VERSION }}
# build-package-generic-unix:
# strategy:
# matrix:
# otp_version:
# - ${{ github.event.inputs.otp_version || '28' }}
# runs-on: ubuntu-latest
# outputs:
# # When dependabot, or a user from a fork, creates PRs, secrets are not injected, and the OCI workflow can't push the image
# # This check acts as a gate keeper
# authorized: ${{ steps.authorized.outputs.authorized }}
# steps:
# - name: CHECK IF IMAGE WILL PUSH
# id: authorized
# run: |
# if [ -n "${{ secrets.DOCKERHUB_PASSWORD }}" ]; then
# echo "authorized=true" | tee -a $GITHUB_OUTPUT
# else
# echo "authorized=false" | tee -a $GITHUB_OUTPUT
# fi
# - name: Checkout
# if: steps.authorized.outputs.authorized == 'true'
# uses: actions/checkout@v4
# - name: Configure Erlang
# if: steps.authorized.outputs.authorized == 'true'
# uses: erlef/setup-beam@v1
# with:
# otp-version: ${{ matrix.otp_version }}
# elixir-version: latest
# - name: make package-generic-unix
# if: steps.authorized.outputs.authorized == 'true'
# run: |
# make package-generic-unix PROJECT_VERSION=${{ env.VERSION }}
# - name: Upload package-generic-unix
# if: steps.authorized.outputs.authorized == 'true'
# uses: actions/upload-artifact@v4
# with:
# name: package-generic-unix-otp${{ matrix.otp_version }}
# path: PACKAGES/rabbitmq-server-*.tar.xz
#
# build-and-push:
# strategy:
# fail-fast: false
# matrix:
# otp_version:
# - ${{ github.event.inputs.otp_version || '28' }}
# needs: build-package-generic-unix
# runs-on: ubuntu-latest
# if: ${{ needs.build-package-generic-unix.outputs.authorized }} == 'true'
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - name: Download package-generic-unix
# uses: actions/download-artifact@v4
# with:
# name: package-generic-unix-otp${{ matrix.otp_version }}
# path: PACKAGES
# - name: Rename package-generic-unix
# run: |
# cp \
# PACKAGES/rabbitmq-server-generic-unix-*.tar.xz \
# packaging/docker-image/package-generic-unix.tar.xz
# - name: Docker meta
# id: meta
# uses: docker/metadata-action@v5
# with:
# images: ${{ env.REGISTRY_IMAGE }}
# flavor: |
# suffix=-otp${{ matrix.otp_version }}
# tags: |
# type=ref,event=branch
# type=ref,event=pr
# type=sha,format=long
# - name: Set up QEMU
# uses: docker/setup-qemu-action@v3
# - name: Set up Docker Buildx
# uses: docker/setup-buildx-action@v3
# - name: Login to Docker Hub
# uses: docker/login-action@v3
# with:
# username: ${{ secrets.DOCKERHUB_USERNAME }}
# password: ${{ secrets.DOCKERHUB_PASSWORD }}
# - name: Build and push by digest
# id: build
# uses: docker/build-push-action@v6
# with:
# push: true
# context: packaging/docker-image
# labels: ${{ steps.meta.outputs.labels }}
# platforms: ${{ github.event.inputs.build_arm && 'linux/amd64, linux/arm64' || 'linux/amd64' }}
# tags: ${{ steps.meta.outputs.tags }}
# cache-to: type=gha,mode=max,scope=${{ matrix.otp_version }}
# cache-from: type=gha,scope=${{ matrix.otp_version }}
# build-args: |
# OTP_VERSION=${{ matrix.otp_version }}
# RABBITMQ_VERSION=${{ env.VERSION }}
2 changes: 1 addition & 1 deletion .github/workflows/test-make-target.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
uses: dsaltares/fetch-gh-release-asset@master
if: inputs.mixed_clusters
with:
version: 'tags/v4.0.9'
version: 'tags/v3.13.7'
regex: true
file: "rabbitmq-server-generic-unix-\\d.+\\.tar\\.xz"
target: ./
Expand Down
152 changes: 77 additions & 75 deletions .github/workflows/test-make.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: Test (make)
on:
workflow_dispatch:
push:
branches:
- main
Expand All @@ -15,96 +16,97 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
jobs:
build-and-xref:
name: Build and Xref
strategy:
fail-fast: false
matrix:
erlang_version:
- '26'
- '27'
- '28'
elixir_version:
- '1.18'
# @todo Add macOS and Windows.
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: CHECKOUT REPOSITORY
uses: actions/checkout@v4

- name: FETCH TAGS
run: git fetch --tags

- name: SETUP OTP & ELIXIR
uses: erlef/setup-beam@v1.19
with:
otp-version: ${{ matrix.erlang_version }}
elixir-version: ${{ matrix.elixir_version }}
hexpm-mirrors: |
https://builds.hex.pm
https://cdn.jsdelivr.net/hex

- name: SANITY CHECK (rabbit)
run: make -C deps/rabbit parallel-ct-sanity-check

- name: SANITY CHECK (rabbitmq_mqtt)
run: make -C deps/rabbitmq_mqtt parallel-ct-sanity-check

- name: BUILD
run: make

- name: XREF
run: make xref

test:
name: Test
strategy:
fail-fast: false
matrix:
erlang_version:
- '28'
elixir_version:
- '1.18'
metadata_store:
- mnesia
- khepri
uses: ./.github/workflows/test-make-tests.yaml
with:
erlang_version: ${{ matrix.erlang_version }}
elixir_version: ${{ matrix.elixir_version }}
metadata_store: ${{ matrix.metadata_store }}
mixed_clusters: false
# DISABLED SINCE WE ARE TESTING MIXED-VERSION ONLY CHANGES FOR NOW
# build-and-xref:
# name: Build and Xref
# strategy:
# fail-fast: false
# matrix:
# erlang_version:
# - '26'
# - '27'
# - '28'
# elixir_version:
# - '1.18'
# # @todo Add macOS and Windows.
# runs-on: ubuntu-latest
# timeout-minutes: 60
# steps:
# - name: CHECKOUT REPOSITORY
# uses: actions/checkout@v4
#
# - name: FETCH TAGS
# run: git fetch --tags
#
# - name: SETUP OTP & ELIXIR
# uses: erlef/setup-beam@v1.19
# with:
# otp-version: ${{ matrix.erlang_version }}
# elixir-version: ${{ matrix.elixir_version }}
# hexpm-mirrors: |
# https://builds.hex.pm
# https://cdn.jsdelivr.net/hex
#
# - name: SANITY CHECK (rabbit)
# run: make -C deps/rabbit parallel-ct-sanity-check
#
# - name: SANITY CHECK (rabbitmq_mqtt)
# run: make -C deps/rabbitmq_mqtt parallel-ct-sanity-check
#
# - name: BUILD
# run: make
#
# - name: XREF
# run: make xref
#
# test:
# name: Test
# strategy:
# fail-fast: false
# matrix:
# erlang_version:
# - '28'
# elixir_version:
# - '1.18'
# metadata_store:
# - mnesia
# - khepri
# uses: ./.github/workflows/test-make-tests.yaml
# with:
# erlang_version: ${{ matrix.erlang_version }}
# elixir_version: ${{ matrix.elixir_version }}
# metadata_store: ${{ matrix.metadata_store }}
# mixed_clusters: false

test-mixed-clusters:
name: Test mixed clusters
strategy:
fail-fast: false
matrix:
erlang_version:
- '28'
- '26'
elixir_version:
- '1.18'
metadata_store:
- mnesia
- khepri
#- khepri # not supported by 3.13
uses: ./.github/workflows/test-make-tests.yaml
with:
erlang_version: ${{ matrix.erlang_version }}
elixir_version: ${{ matrix.elixir_version }}
metadata_store: ${{ matrix.metadata_store }}
mixed_clusters: true

type-check:
name: Type check
strategy:
fail-fast: false
matrix:
erlang_version: # Latest OTP
- '28'
elixir_version: # Latest Elixir
- '1.18'
uses: ./.github/workflows/test-make-type-check.yaml
with:
erlang_version: ${{ matrix.erlang_version }}
elixir_version: ${{ matrix.elixir_version }}
# type-check:
# name: Type check
# strategy:
# fail-fast: false
# matrix:
# erlang_version: # Latest OTP
# - '28'
# elixir_version: # Latest Elixir
# - '1.18'
# uses: ./.github/workflows/test-make-type-check.yaml
# with:
# erlang_version: ${{ matrix.erlang_version }}
# elixir_version: ${{ matrix.elixir_version }}
3 changes: 3 additions & 0 deletions TODO
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- skip AMQP-1.0 tests when using 3.13 - check if works now
- dead-lettering https://github.com/rabbitmq/rabbitmq-server/actions/runs/16000107488/job/45132635443?pr=14171
- QQs https://github.com/rabbitmq/rabbitmq-server/actions/runs/16000107488/job/45132635471?pr=14171
Loading
Loading