CQ: Retry opening file when flushing buffers to avoid "DELETE PENDING" issues on Windows #14108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-cq-dont-delete-current-write-file
branch
2 times, most recently
from
b14bbaf to
415e46e
Compare
lhoguin
commented
Jun 24, 2025
lhoguin
force-pushed
the
loic-cq-dont-delete-current-write-file
branch
from
415e46e to
22e51c0
Compare
On Windows the file may be in "DELETE PENDING" state following
its deletion (when the last message was acked). A subsequent
message leads us to writing to that file again but we can't
and get an {error,eacces}. In that case we wait 10ms and retry
up to 3 times.
lhoguin
force-pushed
the
loic-cq-dont-delete-current-write-file
branch
from
22e51c0 to
ff8ecf1
Compare
lhoguin
changed the title
|
This is ready for review. We need to provide the user with a Windows installer to confirm that it fixes their issue. @michaelklishin How? |
|
you can build a Windows package on a non-windows machine like this: |
|
@lhoguin for every merged PR, we have alpha builds that include a Windows installer. We don't have them for PRs so building the installer locally (on Linux) is the only option. |
|
I'm failing to make it work locally. I will merge the PR and provide a link to the alpha. Thanks! |
|
@Mergifyio backport v4.1.x |
✅ Backports have been created
|
michaelklishin
added a commit
that referenced
this pull request
Jun 25, 2025
CQ: Retry opening file when flushing buffers to avoid "DELETE PENDING" issues on Windows (backport #14108)
|
There's a follow-up PR: #14178. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to prevent issues on Windows when recently deleted files are not immediately available for reopening and writing (they are in "DELETE PENDING").
This is a fix for #14094
Pending further testing.