Skip to content

Fix selenium issue closing popup warning dialog since recent upgrade (backport #13931) #13935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Fix selenium issue closing popup warning dialog since recent upgrade (backport #13931) #13935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion selenium/test/pageobjects/BasePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const ADMIN_TAB = By.css('div#menu ul#tabs li#admin')
const STREAM_CONNECTIONS_TAB = By.css('div#menu ul#tabs li#stream-connections')

const FORM_POPUP_WARNING = By.css('div.form-popup-warn')
const FORM_POPUP_WARNING_CLOSE_BUTTON = By.css('div.form-popup-warn span#close')
const FORM_POPUP_WARNING_CLOSE_BUTTON = By.css('div.form-popup-warn span')

const FORM_POPUP_OPTIONS = By.css('div.form-popup-options')
const ADD_MINUS_BUTTON = By.css('div#main table.list thead tr th.plus-minus')
Expand Down
35 changes: 20 additions & 15 deletions selenium/test/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,28 +64,33 @@ module.exports = {
let chromeCapabilities = Capabilities.chrome();
const options = new chrome.Options()
chromeCapabilities.setAcceptInsecureCerts(true);
let seleniumArgs = [
"--window-size=1920,1080",
"--enable-automation",
"guest",
"disable-infobars",
"--disable-notifications",
"--lang=en",
"--disable-search-engine-choice-screen",
"disable-popup-blocking",
"--credentials_enable_service=false",
"profile.password_manager_enabled=false",
"profile.reduce-security-for-testing",
"profile.managed_default_content_settings.popups=1",
"profile.managed_default_content_settings.notifications.popups=1",
"profile.password_manager_leak_detection=false"
]
if (!runLocal) {
seleniumArgs.push("--headless=new")
}
chromeCapabilities.set('goog:chromeOptions', {
excludeSwitches: [ // disable info bar
'enable-automation',
],
prefs: {
'profile.password_manager_enabled' : false
},
args: [
"--enable-automation",
"guest",
"disable-infobars",
"--disable-notifications",
"--lang=en",
"--disable-search-engine-choice-screen",
"disable-popup-blocking",
"--credentials_enable_service=false",
"profile.password_manager_enabled=false",
"profile.reduce-security-for-testing",
"profile.managed_default_content_settings.popups=1",
"profile.managed_default_content_settings.notifications.popups=1",
"profile.password_manager_leak_detection=false"
]
args: seleniumArgs
});
let driver = builder
.forBrowser('chrome')
Expand Down
Loading