Use more idiomatic maybe feature
#13929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR refactors queue declaration logic to leverage the new maybe expression for more concise error‐handling and removes the now‐unused run_checks/2 helper.
- Stream and quorum queue modules switch from
run_checks/2with an explicitcaseto amaybeblock. - The
run_checks/2function and its export are removed fromrabbit_queue_type_util.erl.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deps/rabbit/src/rabbit_stream_queue.erl | Replaced manual run_checks/2 invocation with a maybe expression in declare/2 for streams |
| deps/rabbit/src/rabbit_quorum_queue.erl | Replaced manual run_checks/2 invocation with a maybe expression in declare/2 for quorums |
| deps/rabbit/src/rabbit_queue_type_util.erl | Removed the run_checks/2 function and export, now unused after the refactoring |
Comments suppressed due to low confidence (2)
deps/rabbit/src/rabbit_stream_queue.erl:140
- Add or update unit tests to cover the new
declare/2branch using themaybeexpression, ensuring both success and error paths for stream queues are exercised.
declare(Q, _Node) when ?amqqueue_is_stream(Q) ->
deps/rabbit/src/rabbit_quorum_queue.erl:251
- Add or update unit tests to cover the new
declare/2branch using themaybeexpression, ensuring both success and error paths for quorum queues are exercised.
maybe
GitHub action Build and Xref on OTP 26 errored with: ``` src/rabbit_quorum_queue.erl:252:9: syntax error before: ok % 252| ok ?= rabbit_queue_type_util:check_auto_delete(Q), % | ^ ```
kjnilsson
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.