Delete single-active-consumer policy #13928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`single-active-consumer` shouldn't be listed under `unsupported_policies` for quorum queues and streams because it isn't a valid policy in the first place, see https://www.rabbitmq.com/docs/consumers#sac-cannot-be-enabled-with-a-policy
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unsupported "single-active-consumer" policy from the capability lists in both quorum queues and streams, in line with the RabbitMQ documentation.
- Removed "single-active-consumer" from rabbit_stream_queue.erl
- Removed "single-active-consumer" from rabbit_quorum_queue.erl
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deps/rabbit/src/rabbit_stream_queue.erl | Removed the unsupported "single-active-consumer" policy from the capabilities list. |
| deps/rabbit/src/rabbit_quorum_queue.erl | Removed the "single-active-consumer" policy from the unsupported policies list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single-active-consumershouldn't be listed underunsupported_policiesfor quorum queues and streams because it isn't a valid policy key in the first place, see https://www.rabbitmq.com/docs/consumers#sac-cannot-be-enabled-with-a-policy