Erlang/OTP 28 compatibility: re:split change; street-address macro #13916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlang/otp#9739 In OTP28+, splitting an empty string returns an empty list, not an empty string (the input). Additionally `street-address` macro was removed in OTP28 - replace with the value it used to be. Lastly, rabbitmq_auth_backend_oauth2 has an MQTT test, so add rabbitmq_mqtt to TEST_DEPS
ansd
reviewed
May 19, 2025
michaelklishin
approved these changes
May 19, 2025
michaelklishin
changed the title
michaelklishin
added a commit
that referenced
this pull request
May 19, 2025
OTP28: re:split change; street-address macro (backport #13916)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
erlang/otp#9739
In OTP28+, splitting an empty string returns an empty list, not an empty string (the input).
Additionally
street-addressmacro was removed in OTP28 - replace with the value it used to be.Lastly, rabbitmq_auth_backend_oauth2 has an MQTT test, so add rabbitmq_mqtt to TEST_DEPS