Skip to content

rabbitmqadmin v1: add default-queue-type to vhost declaration (backport #12386) (backport #12387) #12388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 25, 2024

Proposed Changes

Allow setting the default-queue-type when creating or modifying a vhost via rabbitmqadmin. This is already possible via the Management API and rabbitmqctl. This is a small change that I ran into while trying to update the default-queue-type on a vhost to quorum.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

I couldn't find tests for rabbitmqadmin. Here are the test cases I ran manually.

  1. rabbitmqadmin declare vhost name=new It created a vhost with no default queue type defined.
  2. rabbitmqadmin delcare vhost name=new default_queue_type=quorum It updated the default queue type on the vhost.
  3. rabbitmqadmin declare vhost name=new2 default_queue_type=quorum It create a vhost with the default queue type set to quorum.

This is an automatic backport of pull request #12386 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #12387 done by [Mergify](https://mergify.com).

(cherry picked from commit c3f218d)
(cherry picked from commit 4928e7b)
@michaelklishin michaelklishin merged commit ad74a54 into v3.13.x Sep 25, 2024
182 of 183 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-12387 branch September 25, 2024 21:49
@michaelklishin michaelklishin added this to the 3.13.8 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants