rabbitmqadmin v1: add default-queue-type to vhost declaration (backport #12386) (backport #12387) #12388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow setting the
default-queue-type
when creating or modifying a vhost viarabbitmqadmin
. This is already possible via the Management API andrabbitmqctl
. This is a small change that I ran into while trying to update thedefault-queue-type
on a vhost toquorum
.Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
I couldn't find tests for
rabbitmqadmin
. Here are the test cases I ran manually.rabbitmqadmin declare vhost name=new
It created a vhost with no default queue type defined.rabbitmqadmin delcare vhost name=new default_queue_type=quorum
It updated the default queue type on the vhost.rabbitmqadmin declare vhost name=new2 default_queue_type=quorum
It create a vhost with the default queue type set toquorum
.This is an automatic backport of pull request #12386 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #12387 done by [Mergify](https://mergify.com).