change InboundFrame to a class #1613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changes the InboundFrame to a class instead of a readonly struct. There's only ever one frame active per connection, hence it can be a class that is allocated once and then reused.
benefits
in
).Types of Changes
Checklist
CONTRIBUTING.md
documentFurther Comments
There's a bugfix in here as well, if wanted, I can submit that separately. see my comments.