Skip to content

Back-port https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/145… #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions projects/RabbitMQ.Client/client/impl/ModelBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1194,11 +1194,28 @@ public void BasicPublish(string exchange,
}
}

_Private_BasicPublish(exchange,
routingKey,
mandatory,
basicProperties,
body);
try
{
_Private_BasicPublish(exchange,
routingKey,
mandatory,
basicProperties,
body);
}
catch
{
if (NextPublishSeqNo > 0)
{
lock (_confirmLock)
{
NextPublishSeqNo--;
_pendingDeliveryTags.RemoveLast();
_deliveryTagsCountdown.Reset(_pendingDeliveryTags.Count);
}
}

throw;
}
}

public void UpdateSecret(string newSecret, string reason)
Expand Down
57 changes: 57 additions & 0 deletions projects/Unit/TestConfirmSelect.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
// Copyright (c) 2007-2020 VMware, Inc. All rights reserved.
//---------------------------------------------------------------------------

using System;
using NUnit.Framework;

namespace RabbitMQ.Client.Unit
Expand Down Expand Up @@ -63,5 +64,61 @@ protected void Publish()
{
Model.BasicPublish("", "amq.fanout", null, encoding.GetBytes("message"));
}

[Test]
[TestCase(255)]
[TestCase(256)]
public void TestDeliveryTagDiverged_GH1043(int correlationIdLength)
{
bool.TryParse(Environment.GetEnvironmentVariable("RABBITMQ_VERBOSE"), out bool verbose);

byte[] body = RandomMessageBody();

Model.ExchangeDeclare("sample", "fanout", autoDelete: true);
if (verbose)
{
Model.BasicAcks += (s, e) => Console.WriteLine("Acked {0}", e.DeliveryTag);
}
Model.ConfirmSelect();

IBasicProperties properties = Model.CreateBasicProperties();
if (verbose)
{
Console.WriteLine("Client delivery tag {0}", Model.NextPublishSeqNo);
}
Model.BasicPublish(exchange: "sample", routingKey: string.Empty, properties, body);
Model.WaitForConfirmsOrDie();

try
{
properties = Model.CreateBasicProperties();
properties.CorrelationId = new string('o', correlationIdLength);
if (verbose)
{
Console.WriteLine("Client delivery tag {0}", Model.NextPublishSeqNo);
}
Model.BasicPublish("sample", string.Empty, properties, body);
Model.WaitForConfirmsOrDie();
}
catch (Exception e)
{
if (verbose)
{
Console.WriteLine("Error when trying to publish with long string: {0}", e.Message);
}
}

properties = Model.CreateBasicProperties();
if (verbose)
{
Console.WriteLine("Client delivery tag {0}", Model.NextPublishSeqNo);
}
Model.BasicPublish("sample", string.Empty, properties, body);
Model.WaitForConfirmsOrDie();
if (verbose)
{
Console.WriteLine("I'm done...");
}
}
}
}