Refactor deserialization to support borrowed types #2648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…under the hood. Add `_raw` API to reader/searcher
… example implementations for `DocumentDeserialize` to existing types
…e `RefValue` to ensure no invalid state from objects or arrays
PSeitz-dd
reviewed
Jun 23, 2025
| /// A struct that wraps an `OwnedBytes` and provides a read interface that can be used to read data | ||
| /// from it while borrowing and will not invalidate references | ||
| /// | ||
| /// Useful for zerocopy deserialization since references remain valid after the cursor has advanced |
There was a problem hiding this comment.
you mention zerocopy deserialization deserialization, but below there are several methods that copy bytes
There was a problem hiding this comment.
Those were left over from when I was testing - removed all the methods that are not in use.
The only remaining one is the Read trait which is required for the legacy JSON object parser
…aryDocumentDeserializer so it can be used in type definitions
…ak existing applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.