-
Notifications
You must be signed in to change notification settings - Fork 64
retract v1.9.0 #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retract v1.9.0 #1956
Conversation
WalkthroughAdded a new retract directive in go.mod to retract version v1.9.0 due to a build issue with a dependency. Existing retract for v1.7.0 remains. No other sections of go.mod were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
go.mod (2)
393-393: Fix typo in comment: “dependendy” → “dependency”.Minor nit to keep go.mod tidy and professional.
Apply this diff:
-retract v1.9.0 // build issue with dependendy +retract v1.9.0 // build issue with dependency
392-394: Add a reference for traceability (issue/PR link).Helps future readers understand the rationale behind the retraction.
Optionally update the comment to include the PR number:
-retract v1.9.0 // build issue with dependency +retract v1.9.0 // build issue with dependency (see #1956)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
go.mod(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: test quicksilver (amd64, windows)
- GitHub Check: test quicksilver (darwin, arm64)
- GitHub Check: test quicksilver (amd64, linux)
- GitHub Check: lint
- GitHub Check: Analyze
🔇 Additional comments (2)
go.mod (2)
392-394: LGTM: Retract directive is correct and matches the PR objective.Syntax is valid, placement at the bottom is fine, and this achieves the stated goal of retracting v1.9.0.
393-393: No v1.9.0 pre-release tags detected
All Git tags matchingv1.9.0*(e.g.-rc,-beta) are absent, so only the existingretract v1.9.0 // build issue with dependencyentry is needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
==========================================
- Coverage 57.64% 57.62% -0.02%
==========================================
Files 171 171
Lines 15291 15291
==========================================
- Hits 8815 8812 -3
- Misses 5705 5707 +2
- Partials 771 772 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1. Summary
Fixes build issue with v1.9.0; retracts v1.9.0.
Summary by CodeRabbit