-
Notifications
You must be signed in to change notification settings - Fork 64
Release v1.9.0 #1931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release v1.9.0 #1931
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| package upgrades | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
|
|
||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| "github.com/cosmos/cosmos-sdk/types/module" | ||
| upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types" | ||
|
|
||
| "github.com/quicksilver-zone/quicksilver/app/keepers" | ||
| prtypes "github.com/quicksilver-zone/quicksilver/x/participationrewards/types" | ||
| ) | ||
|
|
||
| func V010900UpgradeHandler( | ||
| mm *module.Manager, | ||
| configurator module.Configurator, | ||
| appKeepers *keepers.AppKeepers, | ||
| ) upgradetypes.UpgradeHandler { | ||
| return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) { | ||
| ctx.Logger().Info("Starting module migrations...") | ||
|
|
||
| if isMainnet(ctx) { | ||
| // add MembraneParams protocol data | ||
| membranePd := prtypes.MembraneProtocolData{ | ||
| ContractAddress: "osmo1gy5gpqqlth0jpm9ydxlmff6g5mpnfvrfxd3mfc8dhyt03waumtzqt8exxr", | ||
| } | ||
|
|
||
| blob, err := json.Marshal(membranePd) | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to marshal membrane protocol data: %w", err)) | ||
| } | ||
|
|
||
| pd := prtypes.NewProtocolData(prtypes.ProtocolDataType_name[int32(prtypes.ProtocolDataTypeMembraneParams)], blob) | ||
| appKeepers.ParticipationRewardsKeeper.SetProtocolData(ctx, membranePd.GenerateKey(), pd) | ||
| } | ||
|
|
||
| ctx.Logger().Info("Upgrade v1.9.0 complete") | ||
| return mm.RunMigrations(ctx, configurator, fromVM) | ||
| } | ||
| } | ||
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify the hardcoded contract address.
The contract address is hardcoded in the upgrade handler. Please ensure this address is correct for the mainnet membrane protocol deployment and consider documenting its purpose.
🏁 Script executed:
Length of output: 4525
Extract and Document the Membrane Contract Address
The address “osmo1gy5gpqqlth0jpm9ydxlmff6g5mpnfvrfxd3mfc8dhyt03waumtzqt8exxr” is used in multiple places:
To avoid duplication and ensure correctness:
• Extract this literal into a single constant (for example
prtypes.MembraneContractAddress) in your module’s types or config package.• Replace the hardcoded strings in the upgrade handler and both test files with that constant:
• Add a doc comment on the constant explaining its origin (mainnet deployment tx or protocol spec) and its role in the Membrane protocol.
• Optionally, update your module’s README or upgrade notes to reference this constant and its purpose.
This centralizes future updates and makes the address’s provenance clear.
📝 Committable suggestion
🤖 Prompt for AI Agents