-
Notifications
You must be signed in to change notification settings - Fork 64
Update xcclookup #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update xcclookup #1920
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f7f97d2
refactor output helpers
joe-bowman 92a1507
add tests for output and mappedAddresses; refactor to remove multierr…
joe-bowman 1430bd6
add cache tests and some more linting
joe-bowman b326cda
add e2e tests to cache test
joe-bowman c9cee0b
refactor xcclookup to be more testable
joe-bowman b61b646
test fixes
joe-bowman 715c996
linty linty
joe-bowman 1fe7983
use unified structured logging; fixes #1922
joe-bowman fe4f8d7
fix reverted cache function returns
joe-bowman 539f278
fix mappedAddress tests
joe-bowman aff61e6
fixes #1926 typo
joe-bowman 53c50f9
fixes #1925; remove legacy annotation
joe-bowman 73c7a12
remove commented line; fixes #1924
joe-bowman c145efb
fixes #1923; remove redundant code
joe-bowman fdb5dd9
lint fixes
joe-bowman 5412b0b
use multierr from uber in place of our own copy
joe-bowman c308291
lint
joe-bowman 90e874b
ensure tests use t.Context()
joe-bowman 5a1fb7c
replace multierror with multierr globally, and be consistent in usage
joe-bowman 2bf4a1b
return empty type instead of nil
joe-bowman 41ab694
consistent and deterministic usage
joe-bowman 323658f
lint
joe-bowman 6be05a6
use multierr consistently
joe-bowman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| //go:build tools | ||
| // +build tools | ||
|
|
||
| package tools | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package utils | ||
|
|
||
| import ( | ||
| "fmt" | ||
| ) | ||
|
|
||
| // helper function to convert error map to slice for multierr | ||
| func ErrorMapToSlice(errs map[string]error) []error { | ||
| var errList []error | ||
| for _, err := range Keys(errs) { | ||
| errList = append(errList, fmt.Errorf("%s: %w", err, errs[err])) | ||
| } | ||
| return errList | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.