Bug Fix to filter uncommitted messages when sorting is disabled and m… #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…axFilesPerTrigger is set Bug/Issue : Incorrect filter condition, leading to no files being given to Spark When working with the connector code, we had to disable the sorting to gain performance improvement in our application. After disabling sorting, we noticed that the condition to filter the uncommitted messages from the cache is incorrect and will always be false. Since we want to filter uncommitted messages, the condition should be looking for files that are not committed, similar to the code flow path here: https://github.com/qubole/s3-sqs-connector/blob/master/src/main/scala/org/apache/spark/sql/streaming/sqs/SqsFileCache.scala#L118
|
@@abhishekd0907 Can you review this change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…axFilesPerTrigger is set
Bug/Issue : Incorrect filter condition, leading to no files being given to Spark
When working with the connector code, we had to disable the sorting to gain performance improvement in our application. After disabling sorting, we noticed that the condition to filter the uncommitted messages from the cache is incorrect and will always be false.
Since we want to filter uncommitted messages, the condition should be looking for files that are not committed, similar to the code flow path here: https://github.com/qubole/s3-sqs-connector/blob/master/src/main/scala/org/apache/spark/sql/streaming/sqs/SqsFileCache.scala#L118