Restart services only if they are monitored by monit #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadoop/util.sh
Outdated
| # Restart services in reverse order of how | ||
| # they were stopped | ||
| for (( i=0; i <last; i++ )); do | ||
| start_daemon "${running_svcs[~i]}" |
There was a problem hiding this comment.
I think it's more readable to loop from $last-1 down to 0, instead of using bitwise negated i as the index. But we can leave it like this if it's idiomatic Bash
There was a problem hiding this comment.
It's pretty standard, but I'm ok with changing it if you feel it's confusing.
akaranjkar-qu
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps avoid cluster-specific checks. e.g. Spark History Server should only be restarted on spark clusters. Instead of checking - in the bootstrap function - if we're running on a spark cluster, the service will be restarted only if it is monitored by monit.
In future this will be extended to handle systemd/upstart.