Skip to content

Update to acmart 2.0 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update to acmart 2.0 #35

wants to merge 2 commits into from

Conversation

dragonstyle
Copy link
Collaborator

@dragonstyle dragonstyle commented Dec 20, 2023

Part 1 of fix to #34
Also fixes #19

This is the version that is currently being distributed via TinyTex/CTAN so updating to ensure compatibility.

Note that `acmPrice` is dropped in this version so removing from partial.
@dragonstyle
Copy link
Collaborator Author

This update appears to be properly using the latest version (which I think is a good idea since CTAN is distributing this version). I did try using the old 'cls' file for simplicity, but other packages (hyperxmp specifically) have updated in ways that broke that version, so sticking with the old version seems a bad idea.

@cscheid Would love your review. Also note that currently when I attempt to render to acm-pdf I think there are tweaks to fancy-figure.lua required - it is currently failing due to our buddy par mode. I'll try to dig into this and fix but if you happen to see his and know what is going on, feel free to party on this branch.

(ending up with this tex:

\begin{figure}

\centering{

\begin{figure}
{\centering \includegraphics{sample-franklin.png}}
\caption{}
\Description{A woman and a girl in white dresses sit in an open car.}
\end{figure}

}

\caption{\label{fig-dresses}1907 Franklin Model D roadster. Photograph
by Harris \& Ewing, Inc.~{[}Public domain{]}, via Wikimedia Commons.
(\url{https://goo.gl/VLCRBB}).}

\end{figure}%

@cderv cderv mentioned this pull request Apr 16, 2025
@cderv cderv marked this pull request as draft April 16, 2025 11:52
@cderv cderv closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Q: Is acmart.cls from this extension supposed to be used?
2 participants