Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 26, 2024

This can be very useful in the logs, especially since we push the scheduler jobs' name into the span name.

Fixes #39703

This can be very useful in the logs, especially since we push the
scheduler jobs' name into the span name.

Fixes quarkusio#39703
@gsmet gsmet requested a review from brunobat December 26, 2024 17:57
Copy link

quarkus-bot bot commented Dec 26, 2024

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

This comment has been minimized.

@brunobat
Copy link
Contributor

To be honest, the amount of storage data that this will cause doesn't justify the benefits... This info can be found in the trace itself and the tracing data in the logs was always meant to be used only for correlation.

@brunobat brunobat closed this Dec 31, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Dec 31, 2024
@brunobat brunobat reopened this Dec 31, 2024
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Dec 31, 2024
Copy link

quarkus-bot bot commented Dec 31, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 88a8c92.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet
Copy link
Member Author

gsmet commented Jan 6, 2025

@brunobat you closed it and then reopened it. Is it by mistake? I'm perfectly fine to close it if you think it has no value but then let's also close the issue as Unplanned.

@brunobat
Copy link
Contributor

brunobat commented Jan 6, 2025

Yes, it was a mistake. I thought it was an issue. I don't like to close PRs from other folks.
... And yes, I don't think we want the functionality.

@gsmet
Copy link
Member Author

gsmet commented Jan 7, 2025

OK, let's close it then.

@gsmet gsmet closed this Jan 7, 2025
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quartz job identifier not set as span name with quartz scheduler OTel tracing

2 participants