Skip to content

Conversation

mariofusco
Copy link
Contributor

Since Drools 10.0.0 is finally out, it's also time to merge the documentation for its Quarkus extension.

@geoand @cescoffier Please review.

@geoand
Copy link
Contributor

geoand commented Dec 16, 2024

🎉

Copy link

github-actions bot commented Dec 16, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of small comments.

Do you plan to add a quickstart as well?

@mariofusco
Copy link
Contributor Author

I added a couple of small comments.

Approved, thanks.

Do you plan to add a quickstart as well?

I wasn't thinking to this, but yes, it's a good idea, I will.

@geoand
Copy link
Contributor

geoand commented Dec 16, 2024

🙏🏽

When done, please squash the commits

@mariofusco
Copy link
Contributor Author

🙏🏽

When done, please squash the commits

Done.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 16, 2024
Copy link

quarkus-bot bot commented Dec 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 40c114d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit b79ae4a into quarkusio:main Dec 16, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 16, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants