-
Notifications
You must be signed in to change notification settings - Fork 3k
Improve JFR integration in Quarkus REST #45059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We are now able to capture events for all HTTP requests that are meant to be handled by Quarkus REST, whether they were successfully handled or not. Fixes: quarkusio#44976
Status for workflow
|
🙏🏽 |
Can/will this be backported to 3.15? |
Unfortunately it's a little too risky for 3.15. What we can do for 3.15 is have a dedicated bug fix that will just prevent the NPE for occuring |
Sounds good. So for 3.15 there will still not be a JFR event recorded, but the original expected status code (ex. 404, 405, 406) will be sent? |
Yeah, that's correct. |
@gsmet do you have a rough idea when we plan to do another 3.15? |
A fix didn't make it into 3.15.3, did it? I don't see a mention of it in the changelog, but maybe I'm just missing it. |
Yeah, that was my bad. I'll make sure we get it in for 3.15.4 |
Thanks! |
Sorry for missing this :( |
@geoand any hint on when 3.15.4 might release? |
The current plan can be found here |
We are now able to capture events for all
HTTP requests that are meant to be handled
by Quarkus REST, whether they were successfully
handled or not.
quarkus-jfr
can cause a NullPointerException #44976