Fix Pulsar DevService network for @QuarkusIntegrationTest for docker-image-building #44265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
jgardo
force-pushed
the
bugfix/pulsar-dev-services-in-it
branch
from
61d1823 to
6f99bbc
Compare
This comment has been minimized.
This comment has been minimized.
gsmet
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I think this looks good, thanks! But I prefer having @ozangunalp 's blessing too.
ozangunalp
approved these changes
Nov 7, 2024
|
|
||
| return getRunningService(container.getContainerId(), container::close, container.getPulsarBrokerUrl(), | ||
| container.getHttpServiceUrl()); | ||
| var pulsarBrokerUrl = container.getPulsarBrokerUrl(); |
There was a problem hiding this comment.
I'd do all this inside the PulsarContainer.
ozangunalp
approved these changes
Nov 12, 2024
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44264
Tested manually for project attached to #44264
Unfortunately I couldn't find any test verifying
@QuarkusIntegrationTestof created docker image...Such tests occurred in the past, but they were dropped in PR #31295 . I suppose these tests were dropped intentionally, as time of CI build was too long.