Adds SentryHttpAnnotation to every @Path and starts a simple Tracing call #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Feluin what you are describing is basically wiring Sentry into existing Quarkus metrics. I think we should find a simple way to plugin and then HTTP calls and JDBC calls would all just work and be forwarded to Sentry. |
|
See this open ticket wants to do the same thing: #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the Spring automatic Tracing https://docs.sentry.io/platforms/java/guides/spring-boot/tracing/instrumentation/automatic-instrumentation/, i would implement a Feature which creates Tracing for every Request. (Later on also maybe JDBC requests).
In This pull Request, i want to collect Ideas on which Data to add to the Span, and also clarifiy, if its a good idea to include this Feature in this Project. Currently the Implementation is merely a Proof of Concept.
Currenly missing at least: