Skip to content

Newer xidlehook versions don't have mode argument to --timer #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions client/plugins/screenlock.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,26 @@ def xidlehook_status(user, display):
timers = []
try:
while args:
# xidlehook timers always have 4 positional arguments
# https://github.com/jD91mZM2/xidlehook/blob/cbc3302e3485a8308d6ba5dd6b4d069d322908dd/src/main.rs#L122 # noqa
# xidlehook timers have either 3 or 4 positional arguments
# depending on the version of xidlehook being used. Older
# versions have "mode" (which can be "normal" or "primary",
# "duration", "command", and "canceller", but newer versions
# (as of 2020-05-24) omit the "mode" argument. Eventually the
# backward-compatibility support for the "mode" argument can
# be removed.
if args[0] == '--timer':
timers.append({
'time': int(args[2]),
'locker': args[3]
})
del args[0:5]
if args[1] in ("normal", "primary"):
timers.append({
'time': int(args[2]),
'locker': args[3]
})
del args[0:5]
else:
timers.append({
'time': int(args[1]),
'locker': args[2]
})
del args[0:4]
else:
args.pop(0)
except Exception:
Expand Down