Modularized adsp, cdsp, and wpss remoteproc tests using common helper functions #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions. Refactored adsp, cdsp, and wpss remoteproc tests. Introduced modular helper usage and standardized logging. Signed-off-by: Sai-teja573 <122cs0573@nitrkl.ac.in>
smuppand
reviewed
Jun 24, 2025
| # Find the remoteproc path for a given firmware substring (e.g., "adsp", "cdsp", "gdsp"). | ||
| get_remoteproc_path_by_firmware() { | ||
| name="$1" | ||
| local idx path |
There was a problem hiding this comment.
Replace local with unscoped variable.
smuppand
reviewed
Jun 24, 2025
| log_fail "$TESTNAME : Test Failed" | ||
| echo "$TESTNAME FAIL" > "$test_path/$TESTNAME.res" | ||
| rproc_path=$(get_remoteproc_path_by_firmware "adsp") || { | ||
| log_fail "$TESTNAME" "adsp remoteproc path not found" |
There was a problem hiding this comment.
It’s better to mark this as info and skip the test, rather than fail it. Since the node isn’t present, further validation isn’t needed. If any additional steps fail, then it would make sense to mark it as a failure.
smuppand
reviewed
Jun 24, 2025
| state=$(get_remoteproc_state "$rproc_path") | ||
| [ "$state" = "running" ] || { | ||
| log_fail "$TESTNAME" "adsp remoteproc not running" | ||
| echo "$TESTNAME FAIL" > "$res_file" |
There was a problem hiding this comment.
What do you think about adding logs or checks to confirm if the firmware loads when a particular subsystem isn’t running? This could help with debugging in CI.
smuppand
requested changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored remoteproc test scripts for adsp, cdsp, and wpss to use modular helper functions from functestlib.sh.
Changes include:
This modularization lays the foundation for extending the same structure to other subsystems like gdsp and general remoteproc validation in future updates.