-
Notifications
You must be signed in to change notification settings - Fork 17
Added Shmbridgee Validation Test script and README #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduced the Shmbridge Validation Test to verify QCOM_SCM support on target devices. This commit includes: - A shell script that checks kernel config and dmesg logs for QCOM_SCM presence and probe status. - A README with usage instructions, prerequisites, and result criteria. This enhances automated validation of Shmbridge functionality in the kernel test suite. Signed-off-by: Sai-teja573 <122cs0573@nitrkl.ac.in>
6b80dd8
to
b1f73e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you intend to validate only config checks and dmesg logs for qcom_scm entries, then it's better to write an additional test instead of removing the existing logic using utils.
check_dependencies zcat grep dmesg | ||
|
||
log_info "Checking kernel config for QCOM_SCM support..." | ||
if ! zcat /proc/config.gz | grep -q "CONFIG_QCOM_SCM"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use check_kernel_config from functestlib.sh#L174
|
||
log_info "Checking kernel config for QCOM_SCM support..." | ||
if ! zcat /proc/config.gz | grep -q "CONFIG_QCOM_SCM"; then | ||
log_fail "$TESTNAME : CONFIG_QCOM_SCM not found in kernel config" | ||
echo "$TESTNAME FAIL" > "$res_file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to mark SKIP if the kernel configuration is not enabled.
log_info "$line" | ||
done | ||
|
||
if echo "$dmesg_output" | grep -qi "probe failure"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between this test and the logic used for checking probe failure here? probe_failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a few additional minor changes, as well as some clarification regarding the probe failure check.
This commit introduces the Shmbridge Validation Test, which verifies the presence and initialization of the QCOM_SCM interface on the target device.
Included in this commit:
This addition enables automated validation of shmbridge functionality as part of the kernel test suite.