Skip to content

Enhance send-to-lava.sh: POSIX-safe, atomic LAVA signal emission #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Jun 20, 2025

This PR enhances the LAVA signal emission process used in [send-to-lava.sh] by:

  • Making the script strictly POSIX-compliant
  • Collecting all valid result lines into a temporary signal buffer
  • Emitting the buffer in one atomic cat operation to avoid race conditions with dmesg
  • Handling malformed or noisy result lines safely
  • Ensuring cleanup of temporary artifacts

These changes were validated on RB3GEN2 and confirmed to resolve earlier issues where LAVA signals were malformed due to interleaved dmesg output.

@smuppand smuppand requested a review from vnarapar June 20, 2025 07:45
@vnarapar
Copy link
Contributor

Please check if qualcomm liscense needs to be added as we are modifying the script now

- Reimplemented the LAVA signal emitter script to be POSIX-compliant, shellcheck-clean, and dmesg-safe.
- Removed FIFO-based signaling and replaced it with a buffered atomic flush approach.
- Handles only valid PASS/FAIL/SKIP/UNKNOWN results with robust parsing.
- Dropped the legacy script sourced from Linaro test definitions and removed the old license file.
- This version ensures clean output, avoids malformed signals, and is CI-friendly.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
@smuppand
Copy link
Contributor Author

Please check if qualcomm liscense needs to be added as we are modifying the script now

Removed the existing license and update with qualcomm license.

@smuppand smuppand closed this Jun 20, 2025
@smuppand smuppand reopened this Jun 20, 2025
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnarapar vnarapar merged commit a7d3701 into qualcomm-linux:main Jun 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants