testlib: Mark test as SKIP if dependencies are missing #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwasilew
requested changes
Jun 11, 2025
| testname="${TESTNAME:-UnknownTest}" | ||
| log_skip "$testname SKIP: missing dependencies:$missing_cmds" | ||
| echo "$testname SKIP" > "./$testname.res" | ||
| exit 0 |
There was a problem hiding this comment.
exit 1?
AFAIK, If you use exit 1, most CI/test systems will treat it as a FAIL, not SKIP.
There was a problem hiding this comment.
that's correct as far as I can tell. In the LAVA test plan here we use || true to avoid this problem. I'm fine leaving it like it is.
- Updated check_dependencies to SKIP tests with missing tools - CI/LAVA now reports SKIP (not FAIL) when commands are absent Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
smuppand
force-pushed
the
skip-deps-patch
branch
from
63c26e8 to
d37f550
Compare
mwasilew
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the check_dependencies function in functestlib.sh to gracefully skip tests when required tools are missing. Instead of failing the test (and reporting as FAIL in CI/LAVA), the test is now marked as SKIP when one or more dependencies are not present in the environment.
Key changes:
This change will reduce noise from false negatives in test dashboards and make it clear when failures are due to missing dependencies rather than actual test or system issues.