Refactor IPA and RMNET tests to use shared module helpers in functestlib.sh #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuppand
force-pushed
the
probe_fail
branch
3 times, most recently
from
38a9263 to
2b3ef6c
Compare
vnarapar
reviewed
Jun 5, 2025
…odule helpers - Introduced shared POSIX-compliant helper functions in functestlib.sh: - find_kernel_module - load_kernel_module - unload_kernel_module - is_module_loaded - Refactored IPA/run.sh and RMNET/run.sh: - Aligned structure for consistency - Replaced hardcoded insmod/lsmod/rmmod logic with shared helpers - Added robust error handling, cleanup logic, and module load validation - Ensured ShellCheck --shell=sh compatibility - Improves modularity, maintainability, and test reliability across CI runs Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a common set of helper functions in functestlib.sh to simplify and standardize kernel module handling across test cases. The following updates are included:
Changes:
Added the following reusable functions to functestlib.sh:
Refactored IPA/run.sh and RMNET/run.sh:
Benefits: