test script for systemd validation #50
Conversation
|
Licence check failure for different files than the one part of change. file license/copyright check > ┌───────────────────────────────────────────┐ |
|
@avisinone Noticed that a few commits are duplicated in this PR (the same changes appear multiple times in the commit history). Please consider rebasing or squashing to remove the duplicates for a cleaner history. Also provide commit message. Also your run.sh is not aligned to run in the testkit suite. Refer https://github.com/smuppand/qcom-linux-testkit/blob/lib_changes/CONTRIBUTING.md |
|
Rebasing your branch on top of main will fix the license issue. Last commit (e4bda8ffad71b14d891e46ec38e1985e85883bcb) in your branch is duplicated from main branch and that causes the problem. |
avisinone
force-pushed
the
platform_test
branch
2 times, most recently
from
0cb77ff to
6bbb509
Compare
| update_test_fail(){ | ||
| subtestname=$1 | ||
| msg=$2 | ||
| echo "$subtestname FAIL" >> "$res_file" |
There was a problem hiding this comment.
Can you please only add Over PASS/Fail status. Since this result file is getting parsed to get the test result, it might give wrong status?
There was a problem hiding this comment.
Hi I have changed the result logic. please check
Following check are implemented : Check systemd starts with PID 1. Check if systemctl start and stop option is able to work for a service. Check for failed service on device using systemctl status. Script returns with exit code 1 if any of the subtest is failed. Usage Command Verified : ./run-test.sh systemd Signed-off-by: Abhishek Sinha <abhsinh@qti.qualcomm.com>
| # shellcheck disable=SC1090,SC1091 | ||
| . "$TOOLS/functestlib.sh" | ||
|
|
||
| TESTNAME="systemd" |
There was a problem hiding this comment.
Better to change name of the test. As it is doing for process check here.
|
|
||
| # Call the functions | ||
| check_systemd_pid | ||
| check_systemctl_stop |
There was a problem hiding this comment.
Better move services check to different script. Any reason to club together?
|
|
||
| ANY_SUBTEST_FAILED="false" | ||
|
|
||
| update_test_pass(){ |
There was a problem hiding this comment.
Can be moved to common functions
No description provided.